Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 245 #274

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Issue 245 #274

merged 7 commits into from
Jul 25, 2024

Conversation

Clerijr
Copy link
Contributor

@Clerijr Clerijr commented Jun 22, 2024

Closes #245

Feature

Adiciona o componente de alteração de senha

Visual evidences

image

Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Additional info Está pendendo o botão de visualizar senha

@Clerijr Clerijr marked this pull request as ready for review June 23, 2024 16:21
@DominMFD DominMFD assigned DominMFD and Clerijr and unassigned DominMFD Jun 24, 2024
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/images/eye-slash.svg Outdated Show resolved Hide resolved
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só precisamos dar uma revisada boa no BEM usado no CSS

Aumenta um pouco o z-index do componente no storybook pq ta aparecendo isso aqui
image

src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.scss Outdated Show resolved Hide resolved
src/components/ChangePassword/index.scss Outdated Show resolved Hide resolved
src/components/ChangePassword/index.scss Outdated Show resolved Hide resolved
src/components/ChangePassword/index.scss Outdated Show resolved Hide resolved
src/components/ChangePassword/index.scss Show resolved Hide resolved
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.scss Outdated Show resolved Hide resolved
@Clerijr Clerijr reopened this Jul 22, 2024
src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.scss Outdated Show resolved Hide resolved
@DominMFD
Copy link
Contributor

Olha eu não sei se você conversou com alguém sobre isso mas seu componente ta diferente do do Figma

seu componente:
image

Figma:
image

particularmente eu gostei mais do seu com as informações em baixo, mas não sei, só vi que ta diferente mesmo e o botão no figma ta lá em baixão.

@DominMFD
Copy link
Contributor

Outra coisa, a ultima eu prometo, quando eu passo o mouse em cima do botão ele fica maior que o componente e cria um scroll no seu componente por causa do efeito de hover que ele tem, aqui ó
image

É só vc colocar um padzinho no componente que arruma isso.

src/components/ChangePassword/index.js Outdated Show resolved Hide resolved
src/components/ChangePassword/index.scss Outdated Show resolved Hide resolved
src/components/ChangePassword/index.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só arrumar as paradas do @DominMFD e GG!

@DominMFD DominMFD merged commit a1d9893 into devhatt:main Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Criar o componente de troca de Senha
3 participants